hapi-sequelize-crud icon indicating copy to clipboard operation
hapi-sequelize-crud copied to clipboard

Add feature to allow nested include and filtering relationships/associations

Open labibramadhan opened this issue 8 years ago • 9 comments

Added feature to allow filtering relationships/associations based on http://docs.sequelizejs.com/en/latest/docs/querying/#relations-associations

labibramadhan avatar Nov 04 '16 05:11 labibramadhan

oops sorry, forgot to fix associationValidation of get-config-for-method.test.js

labibramadhan avatar Nov 04 '16 05:11 labibramadhan

@labibramadhan Thanks Muhammad. May you please document the changes in README, too? The code looks fine to me (though there are lots of space changes, I'm not sure if this style persists throughout the whole codebase) but @joeybaker should take a look, too. :+1:

mdibaiee avatar Nov 04 '16 06:11 mdibaiee

Current coverage is 72.50% (diff: 79.36%)

Merging #36 into master will increase coverage by 9.12%

@@             master        #36   diff @@
==========================================
  Files             9          9          
  Lines           456        480    +24   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            289        348    +59   
+ Misses          167        132    -35   
  Partials          0          0          

Powered by Codecov. Last update 5ba9d7d...05793eb

codecov-io avatar Nov 04 '16 07:11 codecov-io

Hi @mdibaiee, i have added some guide text about this feature in README, please have a check :smiley:

labibramadhan avatar Nov 04 '16 07:11 labibramadhan

By the way i got different indentation settings with your existing scripts, is it OK? what IDE you guys using?

labibramadhan avatar Nov 07 '16 01:11 labibramadhan

@labibramadhan we use two spaces for indentation, almost all IDEs and editors support indentation settings. Thanks for looking at the mentioned issues.

mdibaiee avatar Nov 07 '16 12:11 mdibaiee

anytime @mdibaiee, thank you too @mdibaiee and @joeybaker for this amazing module! i'll give this module a try to my project, but i need to find ACL module to go along, any suggestion?

labibramadhan avatar Nov 08 '16 01:11 labibramadhan

@labibramadhan google tells me that ACL = "access control list", which I take to mean you want find-grain user permissions over REST access?

If so: we're solving this in 2 ways: using the built-in Hapi auth and adding it to our REST routes in defaultConfig, and via scopes.

joeybaker avatar Nov 09 '16 05:11 joeybaker

alright @joeybaker, i will try that method, thank you!

labibramadhan avatar Nov 09 '16 19:11 labibramadhan