sms-analysis icon indicating copy to clipboard operation
sms-analysis copied to clipboard

Move to class system for easier swapping of connectors

Open Neitsch opened this issue 7 years ago • 3 comments

I'd prefer if we use classes for the connectors instead of having stuff in the file scope. This is just an idea :)

Neitsch avatar Feb 15 '18 15:02 Neitsch

I'll do some more testing before moving forward with this :)

Neitsch avatar Feb 19 '18 14:02 Neitsch

Ha okay, I'll hold off then. Read the blog post though and thoroughly enjoyed it.

On Mon, Feb 19, 2018 at 9:38 AM, Nigel Schuster [email protected] wrote:

I'll do some more testing before moving forward with this :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mdezube/sms-analysis/pull/21#issuecomment-366711455, or mute the thread https://github.com/notifications/unsubscribe-auth/ACo82nxxAh1HdWcSP7pGeC-zMQU-AWiAks5tWYdVgaJpZM4SHDlB .

mdezube avatar Feb 20 '18 03:02 mdezube

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB