zha-toolkit icon indicating copy to clipboard operation
zha-toolkit copied to clipboard

Remove the toolbox icon in the ZHA Toolkit integration component name?

Open Hedda opened this issue 1 year ago • 1 comments

Recommend remove toolbox icon in the ZHA Toolkit integration component name as it does not follow HA's name standard. See:

  • https://github.com/home-assistant/frontend/issues/21630

🧰 icon or no 🧰 icon, that is the question?

Suggest just remove special \ud83e\uddf0 character in name "name": "ZHA \ud83e\uddf0 Toolkit", for manifest.json

{
  "domain": "zha_toolkit",
  "name": "ZHA \ud83e\uddf0 Toolkit",
  "codeowners": ["@mdeweerd"],
  "dependencies": ["zha"],
  "documentation": "https://github.com/mdeweerd/zha-toolkit",
  "iot_class": "local_polling",
  "issue_tracker": "https://github.com/mdeweerd/zha-toolkit/issues",
  "requirements": ["aiofiles>=0.4.0", "pytz>=2016.10"],
  "version": "1.0.0"
}

https://github.com/mdeweerd/zha-toolkit/blob/main/custom_components/zha_toolkit/manifest.json

Ping @alexruffell

Hedda avatar Sep 18 '24 12:09 Hedda

@Hedda - I agree the icon should be removed. I actually always mistake it for an old music cassette... showing age here. At least it is no longer before the name where it messed with the sorting, anyhow it is now in the middle and just looks off. Doing away with it is the best option in my opinion - especially if it doesn't follow HA frontend standards.

alexruffell avatar Sep 20 '24 13:09 alexruffell

@mdeweerd Noted tested changing name in component manifest, wondering if changing just the same could break anything?

Hedda avatar Sep 30 '24 06:09 Hedda

Thanks. The icon was moved a bit further in one of the integrated PRs - thanks to the author. I gues this is ok.

mdeweerd avatar Dec 25 '24 21:12 mdeweerd