Maxim Devaev

Results 805 comments of Maxim Devaev

I found a bug: in some cases we got incorrect lanes number. Adding hsync/vsync to calculations (like you did before) brokes calculations at all because of u32 overflow due to...

That's interesting... I'll check the documentation again, maybe I missed some recommendations about calculating periods. By the way, do we really need to calculate the number of lanes dynamically? Why...

Thank you, I'll test it and let you know. The algorithm sounds very plausible. > The fact that tc358743_set_csi handles a return value from tc358743_num_csi_lanes_needed of 0 lanes seems a...

Sorry for the delay. I encountered that division to `V4L2_DV_BT_BLANKING_WIDTH()` causes the error: `ERROR: modpost: "__aeabi_uldivmod" [drivers/media/i2c/tc358743.ko] undefined!`

Okay, it's compiling. But for 1080p@50Hz it gaves 3 lanes instead of 2.

Ah, you're using 16 bit per pixel, I'm testing on 24 bit, so csi2_data_rate=2592000000 in my case. My previous patch gave 4 lines for 1080p@50Hz at RGB24, while the picture...

I'm using this file without line numbers. There is still the problem of "distributed knowledge" about unused fields. That is, I open a file with a description of structures, and...

@jendrikseipp Sup. Could you check the PR? It would be great to start using this in the official release.