Matthew Dempsky
Matthew Dempsky
> This isn't a problem with the old importer because all calls to SetConstraint were deferred FWIW, gcimporter's unified reader still defers them too: https://cs.opensource.google/go/go/+/master:src/go/internal/gcimporter/ureader.go;l=618 If we need to defer...
FWIW, I like the constructor vs non-constructor option. It's certainly very delicate trying to construct cyclic type structures using only the exported APIs. Having some sort of documented guidance on...
According to https://golang.org/doc/go1.16, Go 1.17 will still support macOS 10.13. So should this be deferred to Go 1.18 (or Go 1.23, per @dmitshur)?
I think google/oss-fuzz#3639 should be fixed at go114-fuzz-build master already. Does oss-fuzz automatically pull latest go114-fuzz-build, or does it need to be manually updated? For the copy, I added that...
> yes it pulls from latest master. Good to know. > thanks for thinking on package path. I just pushed df9b762, which I think addresses this. (It turns out cmd/go...
What does the graph represent? What tests were run? What is a "testcase ID"? What's the difference between the orange and blue lines? How do you interpret the graph to...
Sorry, I was asking what the graph in your "experimental results" indicated. Your argument seems to be that the graph demonstrates an experimental improvement on the benchmarks, but it looks...
> What's wrong with init-time assertions? In general, I don't think there's anything wrong with them. But evidently people do like having compile-time assertions, as I've seen the compile-time assert...
@ianlancetaylor That seems like a reasonable counter proposal to me. Do you or @griesemer have any specific spec wording in mind? I'd probably suggest something like: > **Implementation restriction:** If...
Specifically, the supported OS conditions that VS Code cares about are "glibc >= 2.28 and libstdc++ >= 3.4.25".