Matthias Dellweg

Results 96 comments of Matthias Dellweg

I added a test. But the weird thing is, I could not make the test fail. Even though I _think_ I found another place where this content length seems to...

> Actually, looking at the code you've edited. Isn't it already doing that in the next couple of lines: That is the line right after reading and handing down the...

Not sure if that's what you meant (looking at the test). I also broke all the other places that I think prevent sending too many bytes, but still the test...

No, I haven't. But also by this time, I think aiohttp is doing the right thing (see where i broke the writer too). I would have been happy to contribute...

I'm not entirely sure under which circumstances, but this change turns a `SerializerMethodField()` whose name appears in the uniqueness constraint of the underlying model into a `HiddenField(default=None)`. I'll keep investigating.

Here is a (minimal???) reproducer: ```python def test_tba(): class TestModel(models.Model): field_1 = models.IntegerField(null=True) field_2 = models.IntegerField(null=True) class Meta: unique_together = (("field_1", "field_2"),) class TestSerializer(serializers.ModelSerializer): field_1 = serializers.SerializerMethodField() def get_field_1(self) ->...

@jctanner The description about the search vector sounds scary in this context. Shouldn't search be broken, when the search vector does no longer receive updates? Can you gauge whether this...