gravatar_image_tag icon indicating copy to clipboard operation
gravatar_image_tag copied to clipboard

Fix deprecation warnings about using URI.escape method

Open Envek opened this issue 4 years ago • 6 comments

  • [x] Replace obsolete URI.escape method with CGI.escape (no specs failed so it should be fine, I think)
  • [x] Fix deprecation warnings about using ActionView::Base.new in specs
  • [x] Include newer Rails and Ruby versions into CI matrix

Envek avatar Mar 02 '20 10:03 Envek

@mdeering would be great to get this one merged. Thanks

olimart avatar Mar 13 '20 03:03 olimart

@mdeering any chance of getting this merged and released?

szechyjs avatar May 23 '20 00:05 szechyjs

If we can't get it merged and @mdeering isn't responding, is there a more up to date fork of this gem the community is using?

andyjeffries avatar Nov 09 '20 13:11 andyjeffries

Get rid of the dependency with a simple helper

hash = Digest::MD5.hexdigest(email)
"https://secure.gravatar.com/avatar/#{hash}.png?height=#{size}&width=#{size}"

olimart avatar Nov 14 '20 03:11 olimart

thanks @olimart! the url above should be

"https://secure.gravatar.com/avatar/#{hash}.png?s=#{size}"

see: https://en.gravatar.com/site/implement/images#size

michaelglass avatar Dec 11 '20 10:12 michaelglass

@mdeering can we get this merged, please? It breaks when upgrading to ruby 3. Thank you!

paulhklam1122 avatar Nov 17 '21 23:11 paulhklam1122