stripe-scala
stripe-scala copied to clipboard
Plan listing tries to fetch customer
Looks like there is a possible copy-paste error in plans:
https://github.com/mdedetrich/stripe-scala/blob/master/src/main/scala/org/mdedetrich/stripe/v1/Plans.scala#L317
Ok, I fixed this in master.
Plans aren't really covered by integration tests, so if you want to contribute one, it'd be very appreciated.
@mdedetrich Can you release a new version?
@leonardehrenfried,
I am currently testing the following locally: https://github.com/mkoppanen/stripe-scala/commit/96f7918a6718f9b75399e6888aa8588e2664554e
It does look like SubscriptionUpdateInput is not actually necessary as SubscriptionInput could be used.
In my use-case I assign everyone to a subscription, which is "Free Plan" for new users. As they (hopefully) convert into paying users I update the existing subscription to a new plan. In case they are paying and and upgrade the prorating kicks in.
I'll create some unit tests for plans and subscriptions and contribute back.
@mkoppanen Hi there! I was just adding some fixes for Plans (#41). Are you still working on adding unit tests for plans and subscriptions? I'd like to piggy back off of your work.