Mouad Debbar comments

Results 90 comments of


                                            Mouad Debbar

Link widget requires roles, ARIA properties, and keyboard support (Accessibility)

The Link widget is currently implemented as an `` element, which satisfies the request in this issue. Plus there were several semantics improvements for the Link widget here: https://github.com/flutter/packages/pull/6711 I'm...

[web] Fix unresponsive input above SelectionArea in Safari and Firefox.

Thanks for the PR! Let's try to avoid the timer-based solution as much as possible. We need to dig a little deeper here to understand the root cause of the...

[web][tests] Run tests in canvaskit mode

I, too, haven't been able to reproduce the failure locally.

[url_launcher][web] Better support for semantics in the Link widget

Waiting for [this commit](https://github.com/flutter/flutter/commit/8d01fe0565e41ff1ad1b12bd6141fe636d1dc973) to make it to stable.

[camera_web] Re: Support for camera stream on web

/gemini review

Fix: Restore CLI precedence over web_dev_config.yaml

Sorry for the delay here! Help me understand. The way I'm seeing this PR, it seems to fix the precedence for `https` and `headers`. It doesn't change the precedence for...

Fix: Restore CLI precedence over web_dev_config.yaml

@bkonyi does this look good to you? I think we need a 2nd approval to merge.

Remove hardcoded `useWasm: false` for `expectedBenchmarkMetrics()`

> Sorry for missing this! Looks like the `web_benchmarks` package still needs to be published? Yes, there was an issue in the flutter/packages repo that prevented the `web_benchmarks` package from...

Remove hardcoded `useWasm: false` for `expectedBenchmarkMetrics()`

@elliette do you think this PR requires a release notes entry?

#167410: _initCalled completed twice

@srivats22 yes `_isInitCalled` should be private and serve a single purpose: detect when `init()` is called more than once.