true icon indicating copy to clipboard operation
true copied to clipboard

Lots of improvements.

Open tj-commits opened this issue 1 year ago • 3 comments

THESE FIXES ARE CRUCIAL AND SOLVE MANY PROBLEMS

resolves #5 i made the module.exports immutable using @Ginden 's solution resolves #19 i made true not hardcode using @tfrijsewijk's solution also makes bin/cli.js actually log "true". also there was a ./true in the require function in readme.md which is a hint from testing periods. This would not work if someone installed, therefore this is a crucial fix

i have also done the same things but for false on the https://github.com/mde/false mde/false library

tj-commits avatar May 23 '24 16:05 tj-commits

Can we merge pull request

tj-commits avatar May 27 '24 18:05 tj-commits

It's vital to keep such a critical piece of Internet infrastructure free of heavy dependencies, so I'm not keen on this approach. Worth considering if you can find a way to do this without requiring external modules.

mde avatar Jul 06 '24 17:07 mde

@mde Hmm, okay. But besides that I also provided some more fixes. Should those be applied? Like, updating the README.md to be more accurate, and adding CLI to https://github.com/mde/false.

tj-commits avatar Jul 06 '24 21:07 tj-commits