Coloris icon indicating copy to clipboard operation
Coloris copied to clipboard

ARIA: issue with Inline `#clr-color-marker`

Open melloware opened this issue 1 year ago • 6 comments

Using FastPass:

image

Looks like #clr-color-marker its saying there is no role attribute even though it uses aria-label.

Maybe it should be role="presentation"??

melloware avatar Feb 17 '24 17:02 melloware

I did consider what ARIA role to add and I couldn't find anything that fits. There is an open issue related to this on the ARIA Github repo that I've been watching for a while now (https://github.com/w3c/aria/issues/432).

I haven't actually tested the impact of adding role="presentation" to #clr-color-marker on the popular screen readers (JAWS, VoiceOver, NVDA, ...). If you are willing to test it to make sure it doesn't have any negative impact on usability, I'll happily add the role.

mdbassit avatar Feb 19 '24 11:02 mdbassit

@melloware Maybe we can ask @christophs78 to test the change.

jepsar avatar Feb 19 '24 12:02 jepsar

@mdbassit you are right role="presentation" is not correct as the docs say

Note: The element with role="presentation" is not part of the accessibility tree and should not have an accessible name. Do not use aria-labelledby or aria-label.

melloware avatar Feb 19 '24 13:02 melloware

Indeed, role="presentation" is the same as role="none", so it shouldn't be applied to interactive elements.

I think for now we can safely ignore the warning from FastPass. I'm more concerned with how screen readers treat the UI elements than with strictly complying with the standards. I'm open to any suggestions to improve compliance though.

mdbassit avatar Feb 19 '24 14:02 mdbassit

Agreed should we leave this open for tracking and so no one else re-reports it?

melloware avatar Feb 19 '24 14:02 melloware

Alright, let's leave it open for now

mdbassit avatar Feb 19 '24 15:02 mdbassit