pipedream

pipedream copied to clipboard

mdbartos

mdbartos

Add Hazen-Williams and Darcy-Weisbach friction formulations

1

Add HW and DW friction formulations to enable easier conversion between EPANET and pipedream models: https://epanet22.readthedocs.io/en/latest/3_network_model.html#id2 Essentially this involves creating an alternative formulation for S_f in the momentum equation. Ideally,...

mdbartos

mdbartos

Should be: ```python def _compute_bandwidth(At): bandwidth = 0 for k in range(1, len(At)): if np.diag(At, k=k).any(): bandwidth = k else: continue return bandwidth ```

mdbartos

Formula for area and perimeter of parabolic hydraulic geometry are incorrect. Should use computed top width instead of maximum top width.

mdbartos

Velocity and first and last nodes should be the following averages: `u_1k = 0.5 * (Q_uk / A_uk + Q_1k / A_1k)` `u_Np1k = 0.5 * (Q_Nk / A_Nk +...

mdbartos

`suction_head` docstring in infiltration is missing information for parameters.

mdbartos

Labeling issue

1

`chi_ukl` should be `chi_ukm` and `chi_dkm` should be `chi_dkl`.

mdbartos

mdbartos