Marek Darocha

Results 27 comments of Marek Darocha

I made https://github.com/mdarocha/nuget-packageslock2nix, which I use pretty successfully to download NuGet depedendencies based on lock files. The flake above is a drop-in to `buildDotnetModule`, but can be adapted to other...

It seems the new dll is part of a new internal Roslyn LSP server: - https://github.com/dotnet/vscode-csharp/issues/5276#issuecomment-1581651560 - https://github.com/dotnet/roslyn/pull/68461.

> Great work! > Are you going to create a PR to https://github.com/sshnet/SSH.NET with changes from your fork https://github.com/TrapTech/SSH.NET? I dont think thats needed , since my fork just merges...

> Do you mean https://github.com/sshnet/SSH.NET/pull/144 ? I didn't know about this PR. Maybe It should be updated because it stucks in the 2020 year. > Yes, thats the one. Maybe...

> @mdarocha any update? Sorry, didn't have time to work on this. I made https://github.com/sshnet/SSH.NET/pull/1052, and will wait for a response. You can consider this PR dependant on that one....

Unless we refactor this PR to contain only the changes in the main Docker.DotNet project, and keep the Docker.DotNet.SSH out of this repo, as a completely separate, custom nuget? Then...

Ok, I've reverted the changes that add the SSH project and dependencies on the forked SSH library. Now that remains in this PR is enough scaffolding for anyone to hook...

Does the PR look ok to merge in its current state?

@WojciechNagorski @HofmeisterAn I've done a bit of a refactor according to your suggestions

As per the diff: yeah, I normally avoid such situations, but it appears the master branch has some files checked in with CRLF line endings, which caused those problems.