mcuboot icon indicating copy to clipboard operation
mcuboot copied to clipboard

Implement imgtool sanity test in CI

Open davidvincze opened this issue 2 years ago • 4 comments

It has happened before that basic functionalities, commands of imgtool have been broken (e.g. #1746) and it went unnoticed for a while. This issue wants to focus on and track the effort to get a new test implemented as part of the existing imgtool GitHub workflow.

This new sanity test can even be implemented as a Python unit test using one of the existing unit test frameworks or a simple basic bash script that invokes all the available commands of imgtool with different parameters and then compare the output with a known data set (e.g. signed template image, public key... ) to detect regression.

davidvincze avatar Aug 04 '23 10:08 davidvincze

It would be nice. After a brief check - it is even worse now, as #1752 has broken some existing imgtool unittests - so even existing tests are already partially broken as they are not executed by CI. I have created that #1819 as a 1st step to have better imgtool test.

mingulov avatar Sep 26 '23 11:09 mingulov

It would be nice. After a brief check - it is even worse now, as #1752 has broken some existing imgtool unittests - so even existing tests are already partially broken as they are not executed by CI. I have created that #1819 as a 1st step to have better imgtool test.

We've someone working on further additions to #1819 (in progress)

davidvincze avatar Nov 22 '23 12:11 davidvincze

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

github-actions[bot] avatar May 21 '24 01:05 github-actions[bot]

#1819 is in good state, should be merged soon.

davidvincze avatar May 22 '24 08:05 davidvincze