mcuboot icon indicating copy to clipboard operation
mcuboot copied to clipboard

boot: Add MCUBOOT_HW_KEY support for image encryption

Open DineshDK03 opened this issue 2 years ago • 12 comments

Currently encryption supports only private key embed in mcuboot itself. To support MCUBOOT_HW_KEY for image encryption boot_retrieve_private_key() hook is added.

This hook helps retrieving private key from trusted sources like OTP, TPM.

DineshDK03 avatar Jun 08 '23 11:06 DineshDK03

@d3zd3z please revisit.

DineshDK03 avatar Jun 20 '23 09:06 DineshDK03

@d3zd3z Ping

DineshDK03 avatar Jul 03 '23 10:07 DineshDK03

Any update on this ? We have similar solution currently in our software by patching MCUboot, but would highly appreciate if that would be officially available

jimmyzumthurm avatar Oct 25 '23 13:10 jimmyzumthurm

Any update on this ? We have similar solution currently in our software by patching MCUboot, but would highly appreciate if that would be officially available

@jimmyzumthurm. I have already addressed the comments from @mingulov and @d3zd3z and waiting for their acceptance to merge this PR.

DineshDK03 avatar Oct 31 '23 03:10 DineshDK03

Any update on this ? We have similar solution currently in our software by patching MCUboot, but would highly appreciate if that would be officially available

@jimmyzumthurm. I have already addressed the comments from @mingulov and @d3zd3z and waiting for their acceptance to merge this PR.

I am not an official approver / maintainer for MCUboot, so unfortunately my acceptance would not help anyhow.

mingulov avatar Oct 31 '23 07:10 mingulov

@d3zd3z @de-nordic @nordicjm please have a look.

DineshDK03 avatar Nov 01 '23 06:11 DineshDK03

@d3zd3z ping

DineshDK03 avatar Nov 20 '23 07:11 DineshDK03

@sigvartmh

nordicjm avatar Nov 20 '23 07:11 nordicjm

@d3zd3z @sigvartmh @nordicjm @de-nordic please have a look, if all is good, kindly merge this PR.

DineshDK03 avatar Dec 11 '23 09:12 DineshDK03

@d3zd3z Thanks for the review and fixed all the whitespace issues now.

DineshDK03 avatar Dec 13 '23 10:12 DineshDK03

@d3zd3z pushed changes to fix the CI. please approve to run the workflow jobs.

DineshDK03 avatar Dec 25 '23 11:12 DineshDK03

@d3zd3z please have a look, all the comments addressed and waiting to be merged.

DineshDK03 avatar Apr 23 '24 08:04 DineshDK03

@DineshDK03 please add a top commit that adds a release note snippet for this feature. (https://github.com/mcu-tools/mcuboot/blob/main/docs/SubmittingPatches.md#release-notes) Thank you!

davidvincze avatar May 23 '24 15:05 davidvincze

@d3zd3z any other comments on this PR or is it good to go?

davidvincze avatar Jun 05 '24 09:06 davidvincze