mcuboot icon indicating copy to clipboard operation
mcuboot copied to clipboard

`cargo test` with various features fails in mcuboot-sys

Open d3zd3z opened this issue 4 years ago • 2 comments

I discovered, while adding a top-level virtual Cargo.toml file, that cargo test fails to build in mcuboot-sys with some feature combinations. Some quick investigation more makes me wonder why this works at all, as there are some duplicate source files include. It is unclear why, but the link order seems important within mcuboot-sys, whereas it doesn't when linking packages that depend upon it.

This isn't particularly high priority, as there is no strong reason to run these tests (there are no tests, it is just about compilation and linking). But, since the top-level virtual package does include these, it would be nice to have them at least able to link.

d3zd3z avatar Aug 19 '21 20:08 d3zd3z

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

github-actions[bot] avatar Feb 16 '22 01:02 github-actions[bot]

Moving to someday to consider as a possible improvement. Proper linker flags allow us to continue to build even with objects included more than once.

d3zd3z avatar Feb 28 '22 23:02 d3zd3z