mcuboot icon indicating copy to clipboard operation
mcuboot copied to clipboard

scratch section define in zephyr sysflash.h inappropriate

Open Cherish-forever opened this issue 4 years ago • 3 comments

In file zephyr/include/sysflash.h line 42:

#if !defined(CONFIG_BOOT_SWAP_USING_MOVE) #define FLASH_AREA_IMAGE_SCRATCH FLASH_AREA_ID(image_scratch) #endif

that means: CONFIG_BOOT_DIRECT_XIP=y or CONFIG_BOOT_UPGRADE_ONLY=y or CONFIG_BOOT_BOOTSTRAP=y all those config must have scratch, I think CONFIG_BOOT_UPGRADE_ONLY and CONFIG_BOOT_DIRECT_XIP no need scratch section.

Cherish-forever avatar May 14 '21 13:05 Cherish-forever

This suggests we always test with a partition table containing scratch (which makes a little bit of sense, since the test configurations can then also cover the situations with scratch.

This makes sense to test in the simulator.

d3zd3z avatar May 17 '21 14:05 d3zd3z

This issue was also seen on #1004.

utzig avatar May 17 '21 14:05 utzig

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

github-actions[bot] avatar Nov 14 '21 01:11 github-actions[bot]