Max Prokhorov

Results 502 comments of Max Prokhorov

Guess above is about sizing, mostly. You'll have to at least share your EEPROM class setup, not a random sketch that does nothing for our tests :/ `new` can never...

> What setup do you need? Whether you construct EEPROMClass manually, address becomes different. Don't know if you do that. If you have different value for begin() that is not...

> custom_panic_callback Probably just one callback would be ok? We do have custom 'USER' reasons which are private now, but obviously can be moved to a public header. See `rst_reason_sw`....

> Europe/Paris Not using zoneinfo names (i.e. `TZ=:Europe/Paris`, as it would be used on linux) > TZ_Europe_Paris This is intended to be used when building from source, either in code/espurna/config/general.h...

Quoting https://github.com/xoseperez/espurna/issues/2608#issuecomment-2187335260 > ntpTZ is not really a TZ name, but a specification string for either plain offset or DST settings s/ntpTZ/ntpTZ value/ > Anyway, I still think user should...

We have a pretty limited control over the WiFi internals, driver is inside a .a blob coming from the NONOS SDK https://github.com/espressif/ESP8266_NONOS_SDK https://github.com/esp8266/Arduino/tree/master/tools/sdk/lib It *may* be an option for RTOS...

> [@mcspr](https://github.com/mcspr), I would like to discuss implementing a way for the user to override `postmortem_report()`, which would make certain parts of [#9196](https://github.com/esp8266/Arduino/pull/9196) unnecessary. > > Could you please share...

This way we lose last bearssl error since you delete the context obj with `_freeSSL()` call. You might want to save result of `br_ssl_engine_last_error` some place beforehand https://github.com/esp8266/Arduino/blob/1662248b394740d82824f504a021d4dad3d314b6/libraries/ESP8266WiFi/src/WiFiClientSecureBearSSL.cpp#L1347

Yup, RFC seems to imply we *should not* include it https://datatracker.ietf.org/doc/html/rfc7230#section-3.3.2 https://datatracker.ietf.org/doc/html/rfc7230#section-3.3 I would guess our client has a similar problem that Dart's one had at some point https://github.com/dart-lang/sdk/commit/6c254fab89adbeebfb616cdec497260db4cb7cf7 Do...

> Let me know if you prefer I factor out experimental heap_cb.h If it is still a draft, probably makes sense to leave it out of the PR to reduce...