Max Prokhorov

Results 503 comments of Max Prokhorov

Simply run the boards script and commit changes to boards.txt and documentation. Our Check expects that we have the same filesystem contents before and after running it https://github.com/esp8266/Arduino/actions/runs/3099983428/jobs/5202829401 (unfold the...

Notice that keep alive also has this problem. Could we go about fixing the inheritance / class access instead of proxying these methods or adding even more virtual calls?

> I find the multiple inheritance of WiFiClient (in WiFiClientSecure and WiFiClientSecureCtx) confusing > IMO changing the inheritance would result in lot of work quite close to the rule 'if...

(*edit: I am just rude :/ misread the above*) > make remoteIP & co. in WiFiClient virtual as this PR does only for the reasons described above - because the...

... and also ref. https://github.com/esp8266/Arduino/pull/7612#issuecomment-700942104 Meaning, TLS state needs to be the same between copies. Not necessarily in the ClientContext, perhaps in a second helper object (and which is what...

```cpp #include int* somewhere { nullptr }; void setup() { delay(5000); Serial.begin(115200); Serial.printf("%d\n", *somewhere); } void loop() { } ``` ``` --------------- CUT HERE FOR EXCEPTION DECODER --------------- Exception (28):...

Every variant of stack smashing protection seem to utilize a canary value that is either nearby the stack memory or in case of protector just added as an additional stack...

> Second, breakpoint is powerless for memory access violations other than its specified "the point". True, but isn't it enough for functions that allocate some stack and try to operate...

I don't think we have that issue with 'repaints' themselves? It is a separate func call, plus code does not seem to optimize to memset and simply uses loop. Notably,...