Max Prokhorov

Results 502 comments of Max Prokhorov

Some things I should've mentioned earlier: 1. `millis()` value overflows in ~50 days, so direct comparison of time values will become invalid in scheduled callbacks for timer / delay 2....

Per definitions configuration, button limit is 8 (=> uint8_t as mask makes sense) And some useful things for container values: - `uint8_t value{DEFINITION};` instead of `uint8_t value = DEFINITION;` will...

> Is there currently any way I can use the mqtt reporting of a button state whose BUTTON_ACTION is set to NONE? See BUTTON_MQTT_SEND_ALL_EVENTS flag (default off)? I have changed...

I've yet to add this to config list in the Wiki: https://github.com/xoseperez/espurna/blob/e2e0409c5962e4a90ec6632f8636ad88d7841db3/code/espurna/button.ino#L581-L596 `btnRepDel` key can be used for specific button. It will cancel out what WebUI sets, which is global...

I was mistaken about the order above. To actually do that: ```diff diff --git a/code/espurna/button.ino b/code/espurna/button.ino index ff311352..7f5b7796 100644 --- a/code/espurna/button.ino +++ b/code/espurna/button.ino @@ -490,7 +490,7 @@ void _buttonConfigure() {...

Pins can be relaxed imo. We don't depend on the specific version of node, but gulp. PlatformIO I would keep at 3.6.* instead though. What would the flow be to...

Also, ping @wsw70 from https://github.com/xoseperez/espurna/issues/1739

Which is why I wonder if there is any need to use internal source and keep libraries at all. And we also exchange small git history for docker images :/...

> Configure the build process Implement a npm build process on PIO compilation Some previous attempts were here #970 and #1680 , but the way it was done is by...

> Create a new build mode "PWA" that will be the default, it will generate a full PWA app that can be hosted on espurna.io for all users or locally...