Marcin Copik

Results 186 comments of Marcin Copik

Supporting Unix Sockets would have been great for the HTTP client. The asynchronous client is great, we use it all over our projects, but we can't use it to communicate...

@nbcl Thank you so much for your interest in the project! Much appreciated. I think the overall approach is correct; the only issue is that functions should return a dictionary....

@nbcl Do you plan to submit a PR for this, or can someone else work on this feature?

@niranjank2022 Absolutely, feel free to work on this! All contributions are appreciated. In the new output, we should have a boolean `status`, a `result` which should be a string explaining...

@niranjank2022 ~~Benchmarks should not be touched at all - you should only have to modify `handler` functions in `benchmark/wrappers` as they define the final output passed from our executor to...

@niranjank2022 I'm sorry for the confusion - I misread your question and my previous answer was wrong. Handlers defined for each platform and language execute the benchmark, make measurements, and...

@niranjank2022 In every benchmark that gets from the JSON data on bucket access, we should check if these exist. You can do it manually or (better) validate with JSON schema...

@niranjank2022 Thank you for your work! I will try to review the PR soon :)

@octonawish-akcodes There is a pending PR with unresolved review comments #173 - you can work on that and see if you can improve it :) The main remaining issue was...