Matt Connew
Matt Connew
> Nit, indentation --- Refers to: src/libraries/System.Runtime.Serialization.Schema/src/System/Runtime/Serialization/Schema/CodeExporter.cs:305 in 7462bea. [](commit_id = 7462bea6f2e00ccb9405f02fccbe2ae7fe5ef8ef, deletion_comment = False)
> This code previously had a constraint on dataContract.GenericInfo != null. Now it's always running. Are you relying on the earlier condition in the previous if block? Is it possible...
> I know it's equivalent, but I think the code would be easier to read if the comparison was `>= 2` as there's an extra step when reading `> 1`...
Ack on the latest diff, all looks good to me.
@meastp, sorry it took me a while to reply. I've been really busy with the upcoming [CoreWCF](https://github.com/CoreWCF/CoreWCF/) release. `WebOperationContext` is a helper class around OperationContext but as you discovered presumes...
This might fix #15 depending on what the intended final solution is. This might only be a stop gap to prevent the crash if the intention is to display comments...
I had a very quick look at a profiled run of BaconIt and a large part of the problem is how you make requests to the reddit servers. In NetworkManager.MakeGetRequest,...
One downside of the approach I suggested is that JSON.Net will read from the stream synchronously, which will potentially cause an extra thread being used blocking on the read. If...
The implementation looks good. I just did another quick profile and while the memory usage does still spike, it doesn't spike as high as it used to, and the GC...
I hit this issue and have worked out what the problem is. VisualStudio is attaching to the wrong process. It's attaching to the devenv.exe process that's the test instance of...