Matteo Collina
Matteo Collina
I'm +1 on this.
You could make an OS conditional switch. At least this oddity would be transparent for the reader.
@ShogunPanda could d you take a look?
Can you articulate this? I don't see a test.
Seems ok to land as is.
@mhdawson thanks for taking care of this. I made another typo too apparently in another one. We really need more eyes on them before hitting publish.
One note: I'm not aware why those vulnerabilities were classified as critical by others. __THEY ARE NOT__. Update at your own pace, you are almost certainly not at risk as...
@MylesBorins what would be the best way to notify the Github Security Advisories team about this change?
I checked and it's _not_ possible to fix it via GitHub as the information is not copied in that registry.
+1, mainly because @lpinca has been doing a great job in maintaining `ws` the last few years.