Matteo Collina comments

Results 3462 comments of


                                            Matteo Collina

Using typescript and import gives type error: No overload matches this call.

I'm not actively using this module nor typescript, so I'd defer to your best recommendation.

support a singleton logger cache?

I'm really really -1 on this, as it does not work well with multiple versions of the same module in the tree. I'm ok in having a pino-something module that...

support a singleton logger cache?

@davidmarkclements why forcing a wrapping when it's not needed? Passing a its own instance is already possible: https://github.com/pinojs/pino-http/blob/master/logger.js#L22

support a singleton logger cache?

If we have to bump the major for whatever reason, I'm 👍 on this. However, it can wait and we can avoid bumping the major.

support a singleton logger cache?

why all the pinoHttp(instance, stream) business? If you already have a pino instance, why the stream?

Set pino as a peerDependency and pino-pretty as an optionalDependency

Having an optionalDependency will have pino-pretty installed anyway, leading to no benefit at all. I’ll drop the dependency completey in the next major release. As for having pino as a...

Logging non 5xx error details

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Some log messages are not accepted by the elastic search, but pino-elasticsearch does not show any error or warning

@delvedor wdyt?

Can't be used in conjunction with pino-elasticsearch

This is unfortunate but true :(. I don't know if a PR to adjust this would be possible. In case, we'll be happy to land it.

pino should be a peer dependency

peerdependencies do not work well across all package managers. Specifically npm v6 has a significantly different behavior than npm v8 and yarn.