Matteo Collina comments

Results 3365 comments of


                                            Matteo Collina

this.log should be replaced with req.log

> In this case req.raw doesn't contain my originalRoute, not sure why tho. Maybe .child creates copy of original object? Child serializes the request object once at the time the...

rewrite all tests to avoid timers

You can call `t.fail()` in case the something is logged: in that case an error will fail the full suite instead.

Internal stack trace logged

That's a different error. It's this line that gets logged whenever there is no error. https://github.com/pinojs/pino-http/blob/80ec732c9d8c6693b61921a8147fae5715d23d07/logger.js#L46-L50 IMHO we might change it so no stacktrace is actually printed if there is...

Logging responseTime in the message

I don't understand this issue, could you please clarify?

Logging responseTime in the message

Good spot! Would you like to send a PR?

Logging responseTime in the message

yes, exactly. Maybe just an added parameter?

[Feature] Add option which does the opposite of `ignore`

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Docs: `req.id`

Feel free to send a PR with the docs, it would be handy!

Use with ES Modules

I would say that's only for commonjs for now. It might be possible to do this with a module loader.

logger properties dropped when error object provided

Thanks for reporting! You are right, we should probably include all properties in those errors. Would you like to send a PR?