Matteo Collina

Results 3231 comments of Matteo Collina

I think this is a bug in this module: we should throw if we cannot deal with this ambiguity. Better of, we could handle it if it wasn't really hard....

The documentation is incorrect and `onSend` will not be called.

I think this would work as planned in JS but it's failing in TS. Would you like to send a Pull Request to address this issue? Remember to add unit...

> In my case I have to add custom headers on HTTP Upgrade response https://github.com/fastify/fastify-websocket/issues/204 (ws library under the hood, supports it). I would actually prefer to have a PR...

Using Symbol.for would make them part of the public API anyway. I don't think it's a good idea as we would have to support many more use cases than what...

I would actually prefer a PR that adds support for whatever use case you think it's missing rather than exposing internals.

I don't understand, is there a vulnerability somewhere I didn't receive a report on?

Solving this is quite complex and require a lot of rework. Just adding an option to pass in fastify-static does not work from my point of view. peerDependencies are not...