Matteo Collina

Results 3417 comments of Matteo Collina

@mhdawson if any of you can drop a PR for this, it would be very useful to prevent further issues.

is it covered by tests? does it have docs?

Why should we emit a warning? I' m a bit lost on the need

You should be using Node.js v20.16+ and you are using Node.js v18. Apparently we have missed throwing in `create-platformatic` https://github.com/platformatic/platformatic/pull/3168.

I think so too, we should really make this stricter. @Eomm @jsumners wdyt? Should we remove it completely?

I think it makes sense to include a few more frameworks, as the popularity have changed over time. https://npmtrends.com/@hapi/hapi-vs-fastify-vs-h3-vs-hono-vs-koa-vs-restify I think we should include both h3 and hono.

This plugin does not make much sense in fastify v5. This feature is now built in: https://fastify.dev/docs/latest/Reference/Hooks/#diagnostics-channel-hooks.

@ben-hn would you like to send a PR?

The most error prone step is generating CVEs with all the correct metadata associated. I think we should change how we do it, avoid filling the details twice. Ideally, we...