Michael Coker
Michael Coker
These two mq's are nested in another mq and are generating code like below https://github.com/patternfly/patternfly/blob/fec6266a7ad673022ca2e470516ee9978f4343b4/src/patternfly/components/DataList/data-list-grid.scss#L35-L40 https://github.com/patternfly/patternfly/blob/fec6266a7ad673022ca2e470516ee9978f4343b4/src/patternfly/components/Table/table-grid.scss#L532-L536 ``` @media screen and (min-width: 90.625rem) and (min-width: 75rem) { .pf-v6-c-data-list.pf-m-grid-2xl { --pf-v6-c-data-list__item-row--PaddingInlineEnd: var(--pf-v6-c-data-list__item-row--xl--PaddingInlineEnd);...
Found when reviewing visual regressions in https://github.com/patternfly/patternfly/pull/6893 * For some demos, the toolbar should be in the same page section as the thing below it - for example https://patternfly-pr-6893.surge.sh/patterns/card-view/html-demos/card-view/
It's more noticable in react, when you navigate between steps on mobile, and one has a status, the toggle height changes and the wizard content below shifts slightly. https://patternfly-react-v6.surge.sh/components/wizard/react/step-error-status/
Reported by @jamestalton [will add details]
Right now the order in the CSS is: `.[property] {}` -> `.[property][t/r/b/l] {}` -> `.[property][x/y] {}` Which means if you apply `pf-u-mx-lg pf-u-ml-sm` you'll have a large margin left. Here...
https://github.com/patternfly/patternfly/blob/26c9e93352098444abe3fbedfed6dc63bb8fe97b/src/patternfly/components/ModalBox/modal-box.scss#L203-L220 I think the modal footer should be a regular box and if placing actions in it, we recommend using the action list component to mimic the existing styling. That...
These are dupes - https://github.com/patternfly/patternfly/blob/c74620543d6b5640fc9b02d79f91eabde179f30e/src/patternfly/components/Toolbar/toolbar.scss#L426-L436 They're already defined here - https://github.com/patternfly/patternfly/blob/c74620543d6b5640fc9b02d79f91eabde179f30e/src/patternfly/components/Toolbar/toolbar.scss#L201-L239 We could probably have a common block for `__content-section, __group, __item` that sets the 6 modifier classes, since they're...
* `.pf-c-tree-view__action` (actions at the end of the row/node) should be a flex layout to remove space between actions. This would still allow users to pass a flex layout there...
related * https://github.com/patternfly/patternfly/issues/5163 * https://github.com/patternfly/patternfly/issues/5129 _leaving this as needs triage so we can discuss as a group_
looking at the [calendar month examples](https://www.patternfly.org/v4/components/calendar-month), the calendar component has padding around it that will provide space around it wherever it is used. Typically our components don't have padding like...