Michael Coker

Results 206 issues of Michael Coker

Add a form element semantic spacer (the equivalent of `--#{$pf-global}--spacer--form-element`) and set it to the small spacer token, and update any existing references of `--#{$pf-global}--spacer--form-element` to the new token. Then...

Tech debt

We can have a lot of types of sections and we should make sure that the spacing for all is correct, particularly the block spacing when you have all/some of...

Tech debt
Penta

https://github.com/patternfly/patternfly/issues/6242 The form control styles can be used as a reference:

Feature
PF6
Penta

Just want to make sure we handle these. Either remove or see if there are use cases for keeping them but updating to work with penta. https://github.com/patternfly/patternfly/blob/v6/src/patternfly/patternfly-base-no-globals-theme-dark-unversioned.scss https://github.com/patternfly/patternfly/blob/v6/src/patternfly/patternfly-base-theme-dark-unversioned.scss https://github.com/patternfly/patternfly/blob/v6/src/patternfly/patternfly-charts-theme-dark-unversioned.scss https://github.com/patternfly/patternfly/blob/v6/src/patternfly/patternfly-charts-theme-dark.scss...

Tech debt
PF6
Penta

When we have vars that are (explicitly or implicitly) defined by another var, we run the risk of introducing breaking changes if we change any of the vars involved in...

Tech debt
Penta

These should go in controls and buttons/actions https://github.com/patternfly/patternfly/blob/b18cc266d24d9ff894da48e705e5eb4e98b15b60/src/patternfly/base/tokens/_tokens-default.scss#L154-L159

Tech debt
Penta

https://github.com/patternfly/patternfly-react/pull/9500#pullrequestreview-1579141950 from @thatblindgeye > it'd probably be worth updating the docs in Core for the pf-m-progress class to state that it adds padding/transition to the button. The current documentation is...

Stale

In v5, we updated CSS properties with logical property equivalents for padding, margin, borders, insets, etc. To avoid that being a breaking change, we left the CSS var names unchanged,...

Tech debt
PF6
Penta

Notification badge has been replaced with [stateful buttons](https://pf6.patternfly.org/components/button#stateful), so we can drop this component in core, and make mention in release notes that the stateful button should be used instead....

Tech debt
PF6
Penta

Toward https://github.com/patternfly/patternfly-org/issues/3682, we should have an official recommendation for how to swap icons/images and potentially other assets between themes. I have a few ideas in https://github.com/patternfly/patternfly-org/issues/3682, but we should review...

pinned
Tech debt
Post v6