Michael Coker

Results 302 comments of Michael Coker

Hey @CtrlZmaster! I think what you're seeing in the browser's focus outline. In both chrome and firefox, the focus outline is both a blue and white border, and I believe...

> In Chrome, I only get a white outline which looks much better: Ahh, our dark theme styles set the [CSS `color-scheme` property](https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme), which (among other things) changes the focus...

@CtrlZmaster thanks for the issue! I'm only seeing a single border, though the border colors are very light and do look similar to how you've described. I created a codepen...

@CtrlZmaster cool! We're working on a redesign set to release later this year and the outlined label colors look quite a bit better. You can check them out on https://staging-v6.patternfly.org/components/label/#outlined-labels...

cc @andrew-ronaldson and @lboehling for the feedback on the outline label border colors in dark theme. WDYT? Another option could be to override the border colors. If that's something you'd...

I had done some investigation toward this effort during a Day of Learning® and captured said shenanigans in this react PR making react-icons work with SVG symbols - https://github.com/patternfly/patternfly-react/pull/7998 SVG...

Closing for now pending the current workspace improvements work. We can open new issues and revisit if needed.

Attaching the backstop report - [BackstopJS Report.pdf](https://github.com/user-attachments/files/16603370/BackstopJS.Report.pdf) Looks like there may at least be an issue with icons rendering in menu toggles. Here's a toolbar example that's rendering an empty...

@thatblindgeye would you mind reviewing this again? Particularly with the last changeset - https://github.com/patternfly/patternfly/pull/6689/commits/68bd944fad9251671371240be84c270627566bba

cc @lboehling @andrew-ronaldson