amazonica icon indicating copy to clipboard operation
amazonica copied to clipboard

Published 20 hours ago • verified publisher icon mcohen01

Option to use java-time instead of joda

Open conan opened this issue 5 years ago • 5 comments

Currently Amazonica converts java.util.Dates to org.joda.time.DateTimes. Now that we have the time API from Java 8, and good support for it in clojure, it would be great to have an option to work with the native classes, or at least to leave java.util.Dates as they are without conversion.

conan avatar Apr 25 '19 13:04 conan

I think just leave dates alone and/or make the conversion extensible.

interested in a PR? if so, is a breaking change (ie no joda dep) ok?

henryw374 avatar Jul 22 '20 08:07 henryw374

PR here https://github.com/mcohen01/amazonica/pull/431

In the meantime, it's quite straightforward to add one extend-protocol of IMarshall and one alter-var-root of to-date in your own project.

henryw374 avatar Jul 22 '20 13:07 henryw374

I also support moving to standard libraries and dropping extra code. Long term is easier for maintenance, including security related issues (post log4j bulnerabilities). Less is more.

ieugen avatar Jan 25 '22 10:01 ieugen

yeah I actually stopped using Amazonica and use the official java v2 client directly - not difficult from Clojure & it's well documented

henryw374 avatar Jan 25 '22 11:01 henryw374

This'd be very nice to stop us from having to pull in clj-time in all our libraries. We'd prefer to not immediately have to switch to the java SDK or https://github.com/cognitect-labs/aws-api.

Limess avatar Oct 19 '22 11:10 Limess