MCMXC
MCMXC
Warning message from Vite looks ike this now: `@fortawesome/fontawesome-free doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have...
> My next step will be to upgrade nx. We're currently at v13. Don't get your hopes up, happens with nx 14.4.2 as well :(
There are currently two pre-existing test cases called `catch-declares-error-variable` and `event-modifiers-redundant` which are failing the CI now, because they use `on:click` without a key event. Should I adapt these test...
@skippednote I pushed another commit where I fixed the test cases, It is ready for review.
@PatrickG you are right of course. @benmccann I think a contributor from the core team should help out here and specify how strict or loose this rule should be implemented.
oh my bad, thought you are doing both! keep up the good work in Sapper ;)
I understand. So should I close the PR as this rule will not be included in svelte or how should we proceed further?
@Conduitry I improved the implementation to respect following cases: - rule bails out on `aria-hidden`, `type="hidden"` or `role="presentation"` set by user - rule bails out on `a`, `button` and `select`...
@Conduitry I updated this PR a while ago to conform to the requirements, is there a chance to get this reviewed/approved?
Are we waiting for an approval from @Conduitry here or do we have to wait another year for this PR to get merged? ;)