SwarmUI icon indicating copy to clipboard operation
SwarmUI copied to clipboard

Add per-user configurable top-level tab hiding

Open neggles opened this issue 1 year ago • 6 comments

hi fren, it's your worst nightmare, I actually did the thing! and it even accounts for dynamic/extension-added tabs!

well okay it only sort of works. by which I mean it does not work.

the magicks for dropdown popovers appear to be broken with select2's multi-select (since nothing else seems to ever actually call makeMultiselectInput()?) and I am not enough of a JS person to work out how to fix that. So the multiselect shows up, but it's styled wrong, and changing the selected options doesn't mark the option as altered so it's not saveable.

But the hiding does work if I manipulate things in the browser debugger to pretend like the server returned a list of tab IDs to hide.

what do, how fix?

neggles avatar Sep 02 '24 15:09 neggles

Multi-select inputs work as intended locally: image

They look a bit weird but that's mostly just, I never bothered making them fit in well because only a couple params use it.

Scorers and LoRA params are the only multiselects I think exist offhand. Definitely no settings that use em atm, so might need to adjust some code related to Settings to make it process those properly. (Or be lazy and just do a comma separated list as a text input as I did for reuse params exclude list)

mcmonkey4eva avatar Sep 02 '24 19:09 mcmonkey4eva

please don't force push

mcmonkey4eva avatar Sep 03 '24 02:09 mcmonkey4eva

@mcmonkey4eva ok, 2 more force-pushes to undo the first one sry about that 😅

neggles avatar Sep 03 '24 02:09 neggles

OK, made that change and un-drafted this since it's not nearly as cursed now.

[edit] ignore that tiny force push i was missing two spaces

neggles avatar Sep 06 '24 09:09 neggles

per Discord discussion yesterday: should swap this down to just a CSV input for now.

I posted an issue https://github.com/mcmonkeyprojects/SwarmUI/issues/258 to track the need to replace select2 with something that doesn't suck

mcmonkey4eva avatar Sep 12 '24 04:09 mcmonkey4eva

Still haven't gotten to this but will attempt to in the near future 😅

neggles avatar Oct 04 '24 11:10 neggles

Closing as broadly outdated

mcmonkey4eva avatar Feb 03 '25 16:02 mcmonkey4eva