fedex icon indicating copy to clipboard operation
fedex copied to clipboard

ServiceId hardcoded as "crs"

Open sporkd opened this issue 16 years ago • 3 comments

Howdy,

It appears the ServiceId is hardcoded to "crs" inside the WLS_VERSION hash. However ShipService_v7.wsdl requires ServiceId to be set to "ship". Is there a way to override this? If not it appears that only rate has been tested, and a patch will be necessary for label to work.

Peter

sporkd avatar Jan 29 '10 21:01 sporkd

Thanks for letting me know. You're right that I've only really tested the rate service, and I apologize for not having proper tests (I'm working toward that point). There may be a way to override the ServiceId, in fact -- try this:

fedex.label(:Version => { :Major => 7, :Intermediate => 0, :Minor => 0, :ServiceId => "ship" }, ...)

I'd guess that you'd probably have to do the same thing for .cancel as well. I'll work on making this automatic for .ship and .cancel, shouldn't be too much trouble.

mcmire avatar Jan 29 '10 23:01 mcmire

This is fixed in kdonovan's fork, I just need to pull it in...

mcmire avatar Oct 28 '10 15:10 mcmire

Cool. I think kdonovan already merged in all my changes as well, so merging with her branch will get you this fix.

sporkd avatar Oct 28 '10 16:10 sporkd