mcmilk
Add dark mode support
Thx for the PR!
I have few questions about it:
- is exe built with that supposed for dark mode only (or can it automatically and/or per setting switch to light mode)?
- if it is for dark mode only, can we make it optional at runtime or at build phase?
- can we probably rewrite parts of folder
DarkModeas a submodule to darkmodelib repository (or forked darkmodelib here)? Just in order to "simplify" the codebase a bit.
1. is exe built with that supposed for dark mode only (or can it automatically and/or per setting switch to light mode)? 2. if it is for dark mode only, can we make it optional at runtime or at build phase?
By default "classic" color mode is used (current appearance without this PR). Users have basic option to change color mode in settings
or they can use advanced config 7zDark.ini as described here
3. can we probably rewrite parts of folder
DarkModeas a submodule to darkmodelib repository (or forked darkmodelib here)? Just in order to "simplify" the codebase a bit.
Yes that would be better.
I didn't extensively check how are include and source paths defined in 7z build files. so I simple moved DarkModeSubclass.h to src folder with all other files. Then I've used 7zDark.mak and 7zDarkObj.mak.
Also StdAfx.h has specific changes for 7z.
If your patch can use the system style - this should be the default.
Do you think that everything works and is stable?
Quality Gate passed
Issues
232 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
1.0% Duplication on New Code
See analysis details on SonarQube Cloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
If your patch can use the
systemstyle - this should be the default.
Ok
Do you think that everything works and is stable?
I am using for more then 1 year my fork https://github.com/ozone10/7zip-Dark7zip without major issue. Dark mode is achieved via darkmodlib library which is based on code from Notepad++ and it is very stable.
