deep-map icon indicating copy to clipboard operation
deep-map copied to clipboard

Move es6-weak-map to dependencies

Open tgandrews opened this issue 5 years ago • 7 comments

Only dependencies are installed by default by clients and as this is required at runtime it needs to be installed.

Closes #14

tgandrews avatar Feb 01 '19 08:02 tgandrews

Coverage Status

Coverage remained the same at 98.361% when pulling caaf195afa45229968093ffd3a4b7e735c58c2b1 on tgandrews:bug-weak-map-dependency into b99c008ca0e0f4001fe1a691d16a843113bf26fd on mcmath:master.

coveralls avatar Feb 01 '19 08:02 coveralls

Hi, I have the same problem, thanks for creating the PR.

Can you merge it, @mcmath?

Kikobeats avatar Mar 05 '19 19:03 Kikobeats

ping @mcmath

alvis avatar Apr 07 '19 13:04 alvis

hey @mcmath

Kikobeats avatar May 05 '19 18:05 Kikobeats

ping @mcmath

micalevisk avatar May 29 '19 01:05 micalevisk

Because this project looks abandoned, I created map-values-deep using the same test suite and using lodash in the implementation since in the future it would be part of the API.

@tgandrews @micalevisk @alvis

Kikobeats avatar Jun 04 '19 13:06 Kikobeats

Ping @mcmath

henrikhaugboelle avatar Mar 08 '21 15:03 henrikhaugboelle