ideabag2 icon indicating copy to clipboard operation
ideabag2 copied to clipboard

Published 20 hours ago • verified publisher icon mclintprojects

Convert urls in comments to links

Open jarikmarwede opened this issue 6 years ago • 2 comments

I added a method for converting urls in comments to links. It has some flaws. First of all it uses the v-html directive which is vulnerable to XSS attacks. Secondly it splits words by sentences which means it only detects links that have spaces around them on both sides.

jarikmarwede avatar Sep 21 '18 15:09 jarikmarwede

@jarikmarwede Great job. Since users are the ones posting the comments, it'd be risky to go with the v-html solution. I'll try to find out if there's an alternative solution we can try.

mclintprojects avatar Sep 21 '18 16:09 mclintprojects

Thanks, I also forgot to mention that it does not have any styling yet

jarikmarwede avatar Sep 21 '18 16:09 jarikmarwede