wideband icon indicating copy to clipboard operation
wideband copied to clipboard

Published 20 hours ago • verified publisher icon mck1117

remove NoHeaterSupply state

Open mck1117 opened this issue 1 year ago • 2 comments

We don't really need the NoHeaterSupply state, and it was possible to get stuck there, at least on an F042 with "battery emulation".

The behavior of waiting for supply power still applies: we stick in preheat state until the heater is allowed, either via:

  • Command over CAN
  • battery voltage is over HEATER_BATTERY_ON_VOLTAGE for longer than HEATER_BATTERY_STAB_TIME

mck1117 avatar Nov 18 '23 02:11 mck1117

@rusefillc @dron0gus thoughts?

mck1117 avatar Nov 18 '23 02:11 mck1117

Also. In case of Preheat state target heaterVoltage is 2V. For dual boards it is possible that WBO is powered while supply voltage is not applied to sensors (supplied through separate relay, another ignition key position etc). So measured heater voltage is near 0. HeaterControllerBase::Update will calculate and set PWM duty to 100%. Brightly flashing heater LED will confuse user.

dron0gus avatar Dec 10 '23 11:12 dron0gus