wideband icon indicating copy to clipboard operation
wideband copied to clipboard

heater: 5 sec stabilization time after switching to closed loop

Open rusefillc opened this issue 1 year ago • 14 comments

LSU4.2 falls to Underheated state right after switch to closed loop due to rise of sensorEsr (due to applied pump current?)

rusefillc avatar Mar 22 '23 02:03 rusefillc

have a log?

mck1117 avatar Mar 22 '23 02:03 mck1117

Or maybe this is caused by rapidly increased heater PWM? Unlikely. Issue can also be solve by using hysteresis for underheatESR thresholds. Screenshot from 2023-03-22 10-42-17 lsu42_heating.zip

dron0gus avatar Mar 22 '23 07:03 dron0gus

That’s pretty strange. It makes me question the accuracy of the ESR measurement…

mck1117 avatar Mar 22 '23 07:03 mck1117

What happens if you postpone activating the pump until the sensor is fully warm?

mck1117 avatar Mar 22 '23 07:03 mck1117

I'll do some testing later.

dron0gus avatar Mar 22 '23 09:03 dron0gus

Pump control enabled only after sensor reaches targetESR Screenshot from 2023-03-23 00-43-54 lsu42_heating_mod.zip

dron0gus avatar Mar 22 '23 21:03 dron0gus

Looks like Nernst voltage is too low and AC component is clamped. This gives us lower ESR than actually it is. When we start feeding pump with some current Nernst voltage get some shift from zero and AC component is measured correctly. This cause ESR rise/calculated temperature drop. On dial rev1 I have added 0.3V shift to x3 Nernst voltage. Waiting for new HW to check if this helps. Screenshot from 2023-03-23 00-48-17

dron0gus avatar Mar 22 '23 21:03 dron0gus

Yep, this is clamped Nernst. Screenshot from 2023-03-23 01-11-36

dron0gus avatar Mar 22 '23 22:03 dron0gus

seems like at least worth a comment explaining that finding

mck1117 avatar Mar 22 '23 22:03 mck1117

Screenshot from 2023-04-16 13-25-46 Screenshot from 2023-04-16 13-25-00 But this is with 2023-04-16_13.21.46-rev1-warmup.zip 4.9. Needs additional testing with 4.2.

dron0gus avatar Apr 16 '23 10:04 dron0gus

Screenshot from 2023-04-16 13-34-15

dron0gus avatar Apr 16 '23 10:04 dron0gus

So it seems the same bump up in ESR is still there on 4.9, but not as severe, so it doesn't trip underheat.

mck1117 avatar Apr 17 '23 21:04 mck1117

Just rebased this one

@mck1117 @dron0gus are you guys more or less in agreement about this change? @dron0gus can you add additional code comments into this branch? @mck1117 any chance you would be able to merge and add desired code comments?

rusefillc avatar Jul 15 '23 23:07 rusefillc

@mck1117 this was rebased please revisit this PR (fails same as master, will rebase on master when master gets green)

rusefillc avatar Nov 19 '23 14:11 rusefillc