pg_docs_bot icon indicating copy to clipboard operation
pg_docs_bot copied to clipboard

URLs with fragments prevent the notice being displayed

Open mchristofides opened this issue 4 years ago • 0 comments

Some docs URLs use fragments. For example... https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-INT

pg_docs_bot correctly redirects old versions of these to "current", but the search parameter containing the redirected URL is dropped, resulting in the notice not being displayed. From testing, it seems to be happening once on the postgresql.org site, so not sure what can be done about this.

A couple of examples can be seen in this answer on Stack Overflow: https://stackoverflow.com/a/6632280/897147

Update: these are not super commonly linked, or indexed by search engines, and are not the worst failure case (redirect works), so I'm not planning to spend more time on this before v1. The solution may be a different method of storing the redirected URL, or contacting the PostgreSQL website team.

mchristofides avatar Apr 30 '20 21:04 mchristofides