arduino-libs-manchester icon indicating copy to clipboard operation
arduino-libs-manchester copied to clipboard

Recent merge breaks for all but ESP

Open paulhayes opened this issue 7 years ago • 2 comments

Commit 6d001778e43a4c5373cdbaec8e4eceea6c0f04bb breaks this library for attiny85, at328p and atmega32u4, and probably all non ESP boards.

I get the following errors

.piolibdeps/Manchester/Manchester.cpp: In member function 'void Manchester::setupTransmit(uint8_t, uint8_t)':
.piolibdeps/Manchester/Manchester.cpp:92:49: error: 'compensationFactor' was not declared in this scope
delay1 = (HALF_BIT_INTERVAL >> speedFactor) - compensationFactor;
^
.piolibdeps/Manchester/Manchester.cpp: In function 'void MANRX_StopReceive()':
.piolibdeps/Manchester/Manchester.cpp:490:24: error: 'timer' was not declared in this scope
timerDetachInterrupt(timer);
^
.piolibdeps/Manchester/Manchester.cpp:490:29: error: 'timerDetachInterrupt' was not declared in this scope
timerDetachInterrupt(timer);
^

paulhayes avatar Nov 23 '18 17:11 paulhayes

Hi @mchr3k @hjf. Have either of you checked the master branch on a non ESP chip since the pull request / merge. It's pretty broken.

paulhayes avatar Nov 30 '18 18:11 paulhayes

Okay, I've reverted.

mchr3k avatar Nov 30 '18 22:11 mchr3k