sympl icon indicating copy to clipboard operation
sympl copied to clipboard

UpdateFrequencyWrapper bug

Open JoyMonteiro opened this issue 6 years ago • 1 comments

When UFW wraps a TendencyComponent, it should be considered an instance of TendencyComponent. However, sympl currently considers it both a TendencyComponent and ImplicitTendencyComponent, which ends up calling a TendencyComponent with a timestep, causing it to error.

JoyMonteiro avatar Aug 15 '18 20:08 JoyMonteiro

I added a fix to UFW that will retry without passing along the timestep if it gets a TypeError, but the underlying problem that UpdateFrequencyWrapper is considered an ImplicitTendencyComponent regardless of whether it wraps one currently remains.

mcgibbon avatar Aug 15 '18 20:08 mcgibbon