Marc Durdin

Results 376 comments of Marc Durdin

> The one thing I don't like about the fix is that it results in less-documented build scripts - I'd originally specified the `--debug` option in those places so that...

I think you are missing the point. build.sh is intended to be consistent across projects. If it isn't, then we should try and make it so. This is especially the...

@Shreeshrii: as this is your keyboard, would you like to respond to this feedback?

Note: this should not be merged until 17.0 is released.

> I believe it impossible to fully reconcile with roaming touches - even with a more complicated model. Indeed, which is why I have been saying drop roaming touches ......

Oh, please don't merge approved PRs into unapproved PRs -- it makes the review process quite horrible 😒

> I hear you, but ? I don't think I did that…  > > I merged an unreviewed PR here ( #8107 ) which had a refactoring that addressed some...

> I'm trying (and not doing so well i suppose!) to keep PRs small and reviewable. A couple of times I've realized that having a separate PR is counterproductive -...

![image](https://user-images.githubusercontent.com/4498365/215234714-ba90008d-bd27-48ae-8cc5-ea770aae0b73.png) And sometimes GH's annotations aren't helpful -- when a PR is referenced in a dot point, it turns `#xxxx` into a title link...