twitter-streaming-client icon indicating copy to clipboard operation
twitter-streaming-client copied to clipboard

logback.xml should not be included

Open ulsa opened this issue 11 years ago • 3 comments

I think the src/logback.xml should be placed in test or somewhere where it's not included in the released jar. Otherwise it's not deterministic which file is used on the classpath.

00:02:04,950 |-WARN - Resource [logback.xml] occurs multiple times on the classpath.
00:02:04,950 |-WARN - Resource [logback.xml] occurs at [file:/Users/ulrik/Source/Git/twitter-kinesis-lab/twitter-producer/resources/logback.xml]
00:02:04,950 |-WARN - Resource [logback.xml] occurs at [jar:file:/Users/ulrik/.m2/repository/twitter-streaming-client/twitter-streaming-client/0.3.2/twitter-streaming-client-0.3.2.jar!/logback.xml]

ulsa avatar Sep 22 '14 22:09 ulsa

I agree on this, none of the logging wrappers should be carried over as transitive dependencies, maybe we can make them provided or something? Or probably should be marked as runtime as they are not actually used at compile time.

arichiardi avatar Jun 28 '16 01:06 arichiardi

@mccraigmccraig would you be open for me to PR with this and the pruning of the dependencies?

arichiardi avatar Jun 29 '16 02:06 arichiardi

👍 @arichiardi -PR welcome !

mccraigmccraig avatar Jun 29 '16 10:06 mccraigmccraig