arduino-lorawan icon indicating copy to clipboard operation
arduino-lorawan copied to clipboard

Add return statement on Arduino_LoRaWAN::setFrequency

Open olicooper opened this issue 2 years ago • 1 comments

Missing return statement on Arduino_LoRaWAN::setFrequency - causes compile errors. Could be related to an earlier issue I raised? https://github.com/mcci-catena/arduino-lorawan/issues/181

olicooper avatar Jul 31 '22 15:07 olicooper

I can confirm that adding return true; at the end of setFrequency method resolved the core panic on esp32...

vkynchev avatar Aug 25 '22 11:08 vkynchev

I also stumbled on this error

supcik avatar Nov 11 '22 19:11 supcik

Since i'm new to esp32/arduino/lorawan/c++ this cost me hours until i found this pull request :-). Why can't it be merged with master soon?

klauweg avatar Dec 11 '22 20:12 klauweg

Thanks!

terrillmoore avatar Mar 07 '23 05:03 terrillmoore