arduino-lmic icon indicating copy to clipboard operation
arduino-lmic copied to clipboard

LMIC should not assert()

Open terrillmoore opened this issue 6 years ago • 1 comments

assert()s are generally harmful, particularly as they cause a device hang in this implementation (rather than a restart) -- you'll have to roll a truck to get the device going again.

A code review is needed so that places where we currently assert instead:

  • return errors passed back to the caller,
  • continue by substituting sane values, or
  • shut down the LMIC code (potentially reinitializing later)

terrillmoore avatar Feb 07 '18 02:02 terrillmoore