beet icon indicating copy to clipboard operation
beet copied to clipboard

Published 20 hours ago • verified publisher icon mcbeet

feat: add models/equipment and post_effect folders

Open misode opened this issue 1 year ago • 3 comments

Adds these two folders to the resource pack

misode avatar Oct 23 '24 01:10 misode

Running poetry lock should fix the executing 2.0.0 being yanked. There also might be an update we need to make for updating the pack format numbers? Might be good to document the update process in a markdown file, we can work on that after summit.

rx-dev avatar Oct 23 '24 05:10 rx-dev

that odd, my PR did manage to get all dependencies and not this one https://github.com/mcbeet/beet/pull/450

edayot avatar Oct 23 '24 19:10 edayot

Can we get @edayot's branch into this one so there's one 1.21.2 branch that we can merge?

rx-dev avatar Oct 23 '24 19:10 rx-dev

TODO

  • [x] Merge #450 into this (pack formats)
  • [x] items
  • [x] equipments (moved from models/equipment)
  • [x] Figure out custom_model_data merging..
    • [ ] Make it "work fine", handle special logic directly in weld

rx-dev avatar Dec 08 '24 20:12 rx-dev

@RitikShah This PR is ready now. Item model merging will have to be done in a later PR.

misode avatar Dec 08 '24 23:12 misode