Michael Brown

Results 166 comments of Michael Brown

@RobMahn Newer compilers tend to be more strict with warnings, meaning that old versions of the codebase will often trigger warnings that have since been fixed. You can work around...

> [BUILD] bin/int13.o arch/i386/interface/pcbios/int13.c: In function ‘register_int13_drive’: arch/i386/interface/pcbios/int13.c:469:2: warning: ‘asm’ operand 0 probably does not match constraints 469 | **asm** **volatile** ( | ^~~~~~~ arch/i386/interface/pcbios/int13.c:469:2: error: impossible constraint in ‘asm’...

> If I understand correctly, I can only clone from a tag, not a commit. No. For bisection, you clone the current, up-to-date tree, and then start bisecting. You can...

What error did you get on [79697c7](https://github.com/ipxe/ipxe/commit/79697c75eeba01f5068412e03bc5484152f98341) when building with `NO_WERROR=1`?

``` > [BUILD] bin/privkey.o /tmp/cc9xXpcf.s: Assembler messages: /tmp/cc9xXpcf.s:32: Error: missing or invalid displacement expression `private_key_len@GOTOFF' make: *** [Makefile.housekeeping:852: bin/privkey.o] Error 1 ``` That's very odd. The code in `crypto/privkey.c` has...

> In src/usr/pxemenu.c, change: `row = ( LINES - menu->num_items + index );` to `row = ( LINES - 1 - menu->num_items + index ); // Place menu at bottom...

> I cloned your branch and compiled your change. It worked as expected. > > I'm not worried about credit, thank you. I do wonder why you like the menu...

This patch could not have been merged as-is: beyond the extra `efimap` command, it duplicates a substantial amount of logic from `efi_block.c` but with some modifications, which would create extra...

> Totally appreciate this. I imagine the maintenance overhead for something like this is already pretty wild. I will be deploying this across a university as soon as I get...

> This package is the lynchpin in a system we use to admin hundreds of systems. Couldn't live without it. The migration to UEFI was a tough one but with...