Mario Casquero

Results 182 comments of Mario Casquero

> Would you like to help to refine the docstring for each function? even each parameter? > Thanks a lot. @YongxueHong I updated the entire provider script, please feel free...

Test cases passed with latest provider ``` (1/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED (1/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (92.05 s) (2/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED (2/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (92.17 s) RESULTS : PASS 2 | ERROR 0...

> @mcasquer Do we have any windows cases called these new functions? I can help to run them~ @peixiu Sure! See the related patch https://github.com/autotest/tp-qemu/pull/4209 you should be able to...

> Hi @mcasquer I suggest modifying the module name with `disk_utils` to keep the consistency with other modules. Thanks. @YongxueHong done !

@YongxueHong could you review again this PR? Thanks !

Hello @peixiu I've updated the code in both places, could you test it again ? Thanks

Test case passed with latest code on Win11 and Win2025 guests ``` (1/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED (1/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (4178.23 s) (2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED (2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (4159.05 s) (3/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35:...

Hello @peixiu @YongxueHong could you review again this PR? Thanks !

> Any difference with yours? My bad, I've set by default a `tmp_dir` in the cfg of the dependent patch, in addition the code for checking the path was not...

The failed test case is not related with this patch: ``` (1/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED (1/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (205.83 s) (2/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED (2/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: ERROR: Shell command failed: "wmic diskdrive...