dogstatsd-rs icon indicating copy to clipboard operation
dogstatsd-rs copied to clipboard

Various updates

Open mortendahl opened this issue 6 years ago • 2 comments

Various updates:

  • support for passing ints and floats in client methods
  • use enum for metrics
  • rated variants to match the Go client
  • extra options for events (might resolve https://github.com/mcasper/dogstatsd-rs/issues/20)
  • removed most uses of Cow

Regarding rated versions, I would be tempted to remove the non-rated but this means taking &mut self references everywhere; perhaps this isn't an issue. Having rated also means a dependency on rand.

mortendahl avatar May 04 '18 15:05 mortendahl

@mcasper did you see this PR? it looks yummy!

lolgesten avatar Jul 03 '18 14:07 lolgesten

Hey @mortendahl, sorry for the really slow response. There's a lot of great stuff in here! It's a little challenging to review this large of a PR though, could you break the logical changes down into separate PRs for review?

mcasper avatar Feb 24 '19 00:02 mcasper